GHSA-RGG9-956J-3378

Vulnerability from github – Published: 2026-11-19 16:04 – Updated: 2026-11-19 16:04
VLAI
Summary
Mareforma: invalidated claims still promote to REPLICATED
Details

What's wrong

_maybe_update_replicated_unlocked never checks t_invalid, so a claim that a signed contradiction verdict has marked invalid can still climb to REPLICATED through convergence detection, and it pulls an honest peer up with it.

Three gaps line up:

  • The new-claim short-circuit reads only status and asserter_keyid (core.py:1339-1352); an invalidated but still-open new claim passes.
  • The candidate-peer SELECT filters status = 'open', unresolved = 0, and transparency_logged = 1 but has no t_invalid predicate (core.py:1390-1410), so an invalidated existing claim qualifies as a convergence partner.
  • The promotion UPDATE gates only on status = 'open' (core.py:1422-1426), leaving a TOCTOU window even after the SELECT is fixed.

A signed contradiction verdict is meant to be terminal for the trust ladder: validate_claim refuses to promote a t_invalid claim to ESTABLISHED, and record_replication_verdict already gates its promotion UPDATE on t_invalid IS NULL. Convergence promotion is the one path that ignores the verdict. Reproduced at runtime: contradict claim X (t_invalid set, still PRELIMINARY), then assert peer Y sharing X's ESTABLISHED anchor; both X and Y land at REPLICATED, with X's t_invalid still set.

Severity and impact

High. A refuted claim re-enters the trust ladder at REPLICATED after its contradiction, and it serves as the corroborating peer that promotes an honest claim. Both outcomes contradict the documented refutation model, and REPLICATED is the input to further validation.

Location

  • mareforma/db/core.py:1339 new-claim short-circuit checks status and asserter_keyid but not t_invalid
  • mareforma/db/core.py:1390 candidate-peer SELECT WHERE clause has no t_invalid IS NULL predicate
  • mareforma/db/core.py:1422 promotion UPDATE gates on status = 'open' only, reopening the window between SELECT and UPDATE

Fix direction

Treat t_invalid the way the neighboring code already does. Extend the new-claim short-circuit to also read t_invalid and return when it is set. Add AND c.t_invalid IS NULL to the candidate-peer SELECT. Add AND t_invalid IS NULL to the promotion UPDATE's WHERE clause so the row-level lock closes the TOCTOU window, matching the gate record_replication_verdict already applies at core.py:3539.

Do red/green TDD: add a regression test that fails on main, then make it pass.

Quality bar

SOLID, DRY, KISS. Clean, readable, well-tested code. No new errors, warnings, or test failures; the full suite stays green on all supported Python versions.

Show details on source website

{
  "affected": [
    {
      "package": {
        "ecosystem": "PyPI",
        "name": "mareforma"
      },
      "ranges": [
        {
          "events": [
            {
              "introduced": "0.3.0"
            },
            {
              "fixed": "0.3.8"
            }
          ],
          "type": "ECOSYSTEM"
        }
      ]
    }
  ],
  "aliases": [
    "CVE-2026-71500"
  ],
  "database_specific": {
    "cwe_ids": [
      "CWE-754"
    ],
    "github_reviewed": true,
    "github_reviewed_at": "2026-11-19T16:04:43Z",
    "nvd_published_at": "2026-11-18T23:17:21Z",
    "severity": "MODERATE"
  },
  "details": "## What\u0027s wrong\n\n`_maybe_update_replicated_unlocked` never checks `t_invalid`, so a claim that a signed contradiction verdict has marked invalid can still climb to REPLICATED through convergence detection, and it pulls an honest peer up with it.\n\nThree gaps line up:\n\n- The new-claim short-circuit reads only `status` and `asserter_keyid` (`core.py:1339-1352`); an invalidated but still-`open` new claim passes.\n- The candidate-peer SELECT filters `status = \u0027open\u0027`, `unresolved = 0`, and `transparency_logged = 1` but has no `t_invalid` predicate (`core.py:1390-1410`), so an invalidated existing claim qualifies as a convergence partner.\n- The promotion UPDATE gates only on `status = \u0027open\u0027` (`core.py:1422-1426`), leaving a TOCTOU window even after the SELECT is fixed.\n\nA signed contradiction verdict is meant to be terminal for the trust ladder: `validate_claim` refuses to promote a `t_invalid` claim to ESTABLISHED, and `record_replication_verdict` already gates its promotion UPDATE on `t_invalid IS NULL`. Convergence promotion is the one path that ignores the verdict. Reproduced at runtime: contradict claim X (t_invalid set, still PRELIMINARY), then assert peer Y sharing X\u0027s ESTABLISHED anchor; both X and Y land at REPLICATED, with X\u0027s `t_invalid` still set.\n\n## Severity and impact\n\n**High.** A refuted claim re-enters the trust ladder at REPLICATED after its contradiction, and it serves as the corroborating peer that promotes an honest claim. Both outcomes contradict the documented refutation model, and REPLICATED is the input to further validation.\n\n## Location\n\n- `mareforma/db/core.py:1339` new-claim short-circuit checks `status` and `asserter_keyid` but not `t_invalid`\n- `mareforma/db/core.py:1390` candidate-peer SELECT WHERE clause has no `t_invalid IS NULL` predicate\n- `mareforma/db/core.py:1422` promotion UPDATE gates on `status = \u0027open\u0027` only, reopening the window between SELECT and UPDATE\n\n## Fix direction\n\nTreat `t_invalid` the way the neighboring code already does. Extend the new-claim short-circuit to also read `t_invalid` and return when it is set. Add `AND c.t_invalid IS NULL` to the candidate-peer SELECT. Add `AND t_invalid IS NULL` to the promotion UPDATE\u0027s WHERE clause so the row-level lock closes the TOCTOU window, matching the gate `record_replication_verdict` already applies at `core.py:3539`.\n\nDo red/green TDD: add a regression test that fails on `main`, then make it pass.\n\n## Quality bar\n\nSOLID, DRY, KISS. Clean, readable, well-tested code. No new errors, warnings, or test failures; the full suite stays green on all supported Python versions.",
  "id": "GHSA-rgg9-956j-3378",
  "modified": "2026-11-19T16:04:43Z",
  "published": "2026-11-19T16:04:43Z",
  "references": [
    {
      "type": "WEB",
      "url": "https://github.com/mareforma/mareforma/security/advisories/GHSA-rgg9-956j-3378"
    },
    {
      "type": "ADVISORY",
      "url": "https://nvd.nist.gov/vuln/detail/CVE-2026-71500"
    },
    {
      "type": "WEB",
      "url": "https://github.com/mareforma/mareforma/pull/58"
    },
    {
      "type": "WEB",
      "url": "https://github.com/mareforma/mareforma/commit/c9d8922132d916e4fd013890cb4e17921e00065e"
    },
    {
      "type": "PACKAGE",
      "url": "https://github.com/mareforma/mareforma"
    },
    {
      "type": "WEB",
      "url": "https://github.com/mareforma/mareforma/releases/tag/v0.3.8"
    }
  ],
  "schema_version": "1.4.0",
  "severity": [
    {
      "score": "CVSS:4.0/AV:L/AC:L/AT:P/PR:L/UI:N/VC:N/VI:H/VA:N/SC:N/SI:H/SA:N",
      "type": "CVSS_V4"
    }
  ],
  "summary": "Mareforma: invalidated claims still promote to REPLICATED"
}



Log in or create an account to share your comment.




Tags
Taxonomy of the tags.


Loading…

Loading…

Loading…

Forecast uses a logistic model when the trend is rising, or an exponential decay model when the trend is falling. Fitted via linearized least squares.

Sightings

Author Source Type Date Other

Nomenclature

  • Seen: The vulnerability was mentioned, discussed, or observed by the user.
  • Confirmed: The vulnerability has been validated from an analyst's perspective.
  • Published Proof of Concept: A public proof of concept is available for this vulnerability.
  • Exploited: The vulnerability was observed as exploited by the user who reported the sighting.
  • Patched: The vulnerability was observed as successfully patched by the user who reported the sighting.
  • Not exploited: The vulnerability was not observed as exploited by the user who reported the sighting.
  • Not confirmed: The user expressed doubt about the validity of the vulnerability.
  • Not patched: The vulnerability was not observed as successfully patched by the user who reported the sighting.

Loading…

Loading…

Loading…

Related by attack behaviour

Vulnerabilities whose description is nearest to this one in the vector space of the CIRCL/vulnerability-attack-technique-biencoder model. This is a similarity search over the bi-encoder space (plain cosine), not a classification, and it has no measured accuracy.


Loading…